Add copy variables from Heroku to the menu #35
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is very old and I don't believe we need it any longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: I have to add that this does not work for me because I have enabled multi-factor authentication on Heroku.
I doubt that I am the only one who has done that. Therefore, there will be others this will not work for.
But, I can simply log into Heroku and see all my variables.
That is why I prefer not to have this added to the menu.
This PR changes the menu.
It removed edit variables because we now have edit variables using a browser.
It adds copy variables from Heroku. This is an existing utility.
It changes the order of some of the items on the menu.
This is the new menu after this PR:
How to test (how it was tested):
In your updated test virtual machine, edit the following file: /xDrip/scripts/menu.sh
Replace the content with the file from this PR, the only modified item: https://github.com/Navid200/cgm-remote-monitor/blob/CopyVarsMenu/menu.sh
Close the terminal. Open a new window.
Leave testing "Update scripts" to last. Using that item will update the menu back to the way it was.