Skip to content

Conversation

@megawac
Copy link
Collaborator

@megawac megawac commented Aug 4, 2014

These cases are probably not very important anyway if #1758 is merged as it can be handled by via negative indexes to slice.

@akre54
Copy link
Collaborator

akre54 commented Sep 11, 2014

The perf diff is negligible and I dig the reusability. We can cross the _.slice stream when we come to it.

akre54 added a commit that referenced this pull request Sep 11, 2014
First and last via initial/rest
@akre54 akre54 merged commit 8a25495 into jashkenas:master Sep 11, 2014
@megawac megawac deleted the samplers branch September 11, 2014 15:46
@jdalton
Copy link
Contributor

jdalton commented Sep 11, 2014

I donno if it matters but you were perf testing the wrong thing since the _.rest and _.initial use only kick in when the methods are passed an n value.

@akre54
Copy link
Collaborator

akre54 commented Sep 11, 2014

Oops, updated. Still isn't horrible though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants