Skip to content

another take at allowing for array of iteratees in sortBy #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krawaller wants to merge 4 commits into from
Closed

another take at allowing for array of iteratees in sortBy #1815

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a48ac1
allowed for array of iteratees in sortBy
krawaller Aug 29, 2014
5d6861e
fixed test to make sure iteratees can be functions
krawaller Aug 29, 2014
98e7175
storing iteratees length
krawaller Aug 29, 2014
8896c90
fixed style errors in Travis build
krawaller Aug 29, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
storing iteratees length
  • Loading branch information
@krawaller
krawaller committed Aug 29, 2014
commit 98e71757f8e7d2769c7588196bff734f7894c0d4
3 changes: 2 additions & 1 deletion underscore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,14 +337,15 @@
// Sort the object's values by a criterion produced by one or more iteratees.
_.sortBy = function(obj, iteratee, context) {
var iteratees = [].concat(iteratee).map(function(i){return _.iteratee(i,context)});
var length = iteratees.length;
return _.pluck(_.map(obj, function(value, index, list) {
return {
value: value,
index: index,
criterias: _.map(iteratees,function(it){return it(value,index,list)})
};
}).sort(function(left, right) {
for (var n = 0; n < left.criterias.length; n++) {
for (var n = 0; n < length; n++) {
var a = left.criterias[n];
var b = right.criterias[n];
if (a !== b) {
Expand Down