Skip to content

Conversation

@jaworskig00
Copy link
Owner

No description provided.

@jaworskig00 jaworskig00 requested a review from k1eu July 27, 2022 14:00
Copy link
Collaborator

@k1eu k1eu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is good, even MP himself approved it.
Other than the code always look for the package-lock.json vs yarn.lock. By having those files u can diffrentiate where to use NPM vs YARN. Also if you're not installing anything new, don't commit lock changes

Comment on lines +6 to +29
const One = ({children}) => {
return (
<div className='App-box'>
One
{children}
</div>
)
};
const Two = ({children}) => {
return (
<div className='App-box'>
Two
{children}
</div>
)
};
const Three = ({children}) => {
return (
<div className='App-box'>
Three
{children}
</div>
)
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabs formatting in that file

@jaworskig00
Copy link
Owner Author

Logic is good, even MP himself approved it.

Other than the code always look for the package-lock.json vs yarn.lock. By having those files u can diffrentiate where to use NPM vs YARN. Also if you're not installing anything new, don't commit lock changes

Understood, thank you ♥️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants