Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: react-native 0.33 compatibility
  • Loading branch information
nadeesha committed Dec 26, 2016
commit 6eba831ff959ab5a50eb68f9cdd85a0e6b4a9946
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ android {
}

dependencies {
compile 'com.facebook.react:react-native:0.11.+'
compile 'com.facebook.react:react-native:0.33.+'
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,8 @@
import com.facebook.react.bridge.ReactMethod;

public class ActivityAndroidModule extends ReactContextBaseJavaModule implements LifecycleEventListener {
private Activity mCurrentActivity;

public ActivityAndroidModule(ReactApplicationContext reactContext, Activity activity) {
public ActivityAndroidModule(ReactApplicationContext reactContext) {
super(reactContext);
mCurrentActivity = activity;
reactContext.addLifecycleEventListener(this);
}

Expand All @@ -30,7 +27,7 @@ public String getName() {

@ReactMethod
public void moveTaskToBack(Callback onSuccess, Callback onError) {
boolean wasMoved = mCurrentActivity.moveTaskToBack(true);
boolean wasMoved = getCurrentActivity().moveTaskToBack(true);

if (wasMoved) {
onSuccess.invoke();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,14 @@
import java.util.List;

public class ActivityAndroidPackage implements ReactPackage {
private Activity mCurrentActivity;
public ActivityAndroidPackage() {

public ActivityAndroidPackage(Activity activity) {
mCurrentActivity = activity;
}

@Override
public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
return Arrays.<NativeModule>asList(
new ActivityAndroidModule(reactContext, mCurrentActivity)
new ActivityAndroidModule(reactContext)
);
}

Expand Down