Skip to content

Fix crash with pip==25.1, which changed caching for find_all_candidates #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gkreitz wants to merge 2 commits into from
Closed

Fix crash with pip==25.1, which changed caching for find_all_candidates #2178

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c46b71
Fix crash with pip==25.1, which changed caching for find_all_candidates
gkreitz Apr 29, 2025
7f354a2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions piptools/repositories/pypi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,9 +447,13 @@ def _wheel_support_index_min(self: Wheel, tags: list[Tag]) -> int:
Wheel.support_index_min = _wheel_support_index_min
self._available_candidates_cache = {}

# If we don't clear this cache then it can contain results from an
# earlier call when allow_all_wheels wasn't active. See GH-1532
self.finder.find_all_candidates.cache_clear()
# Finder internally caches results, and there is no public method to
# clear the cache, so we re-create the object here. If we don't clear
# this cache then it can contain results from an earlier call when
# allow_all_wheels wasn't active. See GH-1532
self._finder = self.command._build_package_finder(
options=self.options, session=self.session
)

try:
yield
Expand Down