Correctly get array item types in CNF deployment parameter schemas #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When grabbing the types of deployment parameters from the values.schema.json, we retrieve the overall array object where there is an array, and thus get "array" as the type. This fix checks for an "items" entry in the schema and extracts the type from that (defaulting to string if not provided, as with objects).
For now this only supports cases where all values have the same type - where there are multiple values, we default to string and display the usual warning.
Also, extend the basic CNF test's example mapping file to include a deployment parameter in an array and test that the resultant schema correctly includes the type.