fix(bootstrap): wrong directory on first run #6971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current bootstrap code switch directory to the project directory on first install (which is hardcoded to be 2 parents up from the bootstrap script).
This fails when calling command with relative path, if the project directory is not 2 level up, or if the user was not at the root of the project.
Once mise is installed, no directory change happen.
This fix restore the current working directory after install.
I also simplified the code that generate
project_dirto avoid 2 subshell.Test plan
Manually tested the generated bootstrap with and without the
--localizeoption.Note
Keeps the original working directory after first-time install and simplifies localized project_dir detection, removing MISE_BOOTSTRAP_PROJECT_DIR usage.
$PWDandcd-ing back.project_dirresolution in localized mode using the script path (${BASH_SOURCE[0]}) andcd ...MISE_BOOTSTRAP_PROJECT_DIRand related directory switching; keep localized env exports andMISE_INSTALL_PATHsetup intact.Written by Cursor Bugbot for commit 0046115. This will update automatically on new commits. Configure here.