feat(plugins): Install a plugin from a zip file over HTTPS #6992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
this needs support and tests for vfox as well. There's also a bunch of code that this should be reusing from file.rs. |
Contributor
Author
|
Thanks for the review, I refactored the old code and added support for vfox. Can you recheck the implementation ? |
Contributor
Author
|
Just checking in on this PR, let me know if you need anything else from me |
jdx
reviewed
Nov 24, 2025
src/plugins/asdf_plugin.rs
Outdated
| async fn download_zip(&self, url: &str, pr: &dyn SingleReport) -> eyre::Result<Vec<u8>> { | ||
| pr.set_message(format!("downloading {url}")); | ||
|
|
||
| let client = reqwest::Client::builder().user_agent("mise").build()?; |
Owner
There was a problem hiding this comment.
this needs significantly more refactoring, you should not be creating raw reqwest structs
Contributor
Author
There was a problem hiding this comment.
Sorry for the oversight, I should have checked the repo for existing reqwest usages. I’ve fixed the issue now. When you have a moment, could you re-review it?
jdx
pushed a commit
that referenced
this pull request
Nov 26, 2025
### 📦 Registry - add blender by @lucasew in [#7014](#7014) - add vespa-cli by @buinauskas in [#7037](#7037) - fix vespa-cli order by @buinauskas in [#7038](#7038) - add scooter by @TyceHerrman in [#7039](#7039) - Prefer github backend for allure by @TobiX in [#7049](#7049) ### 🚀 Features - **(plugins)** Install a plugin from a zip file over HTTPS by @KaanYT in [#6992](#6992) - **(registry)** add tool options support for http backend by @jdx in [#7061](#7061) ### 🐛 Bug Fixes - **(core)** trim `core:` prefix in unalias_backend by @kou029w in [#7040](#7040) - **(go)** use -mod=readonly for go install by @joonas in [#7052](#7052) - **(npm)** handle v-prefixed versions correctly by @jdx in [#7062](#7062) - **(tasks)** add missing task fields to JSON output by @roele in [#7044](#7044) - semver in aqua by @lucasew in [#7018](#7018) - use the musl version if installing in Android (Termux) by @lucasew in [#7027](#7027) - empty enable_tools crash by @moshen in [#7035](#7035) ### 📚 Documentation - add MISE and USAGE syntax hl queries to neovim cookbook by @okuuva in [#7047](#7047) - use local assets for screenshots by @okuuva in [#7056](#7056) - remove GitHub issues link from roadmap by @jdx in [6897286](6897286) ### 📦️ Dependency Updates - update docker/metadata-action digest to 318604b by @renovate[bot] in [#7033](#7033) - update actions/checkout digest to 34e1148 by @renovate[bot] in [#7032](#7032) - lock file maintenance by @renovate[bot] in [#7048](#7048) ### Chore - upgrade actionlint to 1.7.9 and fix lint issues by @jdx in [#7065](#7065) ### New Contributors - @joonas made their first contribution in [#7052](#7052) - @KaanYT made their first contribution in [#6992](#6992) - @kou029w made their first contribution in [#7040](#7040) - @moshen made their first contribution in [#7035](#7035) - @buinauskas made their first contribution in [#7038](#7038) - @lucasew made their first contribution in [#7014](#7014) ## 📦 Aqua Registry Updates #### New Packages (3) - [`m7medVision/lazycommit`](https://github.com/m7medVision/lazycommit) - [`microsoft/component-detection`](https://github.com/microsoft/component-detection) - [`owenlamont/ryl`](https://github.com/owenlamont/ryl) #### Updated Packages (1) - [`sst/opencode`](https://github.com/sst/opencode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install a asdf plugin from a zip
This is useful for: