-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(tasks): add usage args to Tera context in run scripts
#7041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
1ae91b8
feat: add experimental option to disable spec collection from run scr…
iamkroot e2d3e13
[autofix.ci] apply automated fixes
autofix-ci[bot] e49296a
Add multistring test
iamkroot 62e81b6
Fix test
iamkroot 59ca10e
Code cleanup
iamkroot 4935eb5
Fix tests
iamkroot 59ba26e
[autofix.ci] apply automated fixes
autofix-ci[bot] 866ed1d
Always inject usage map into run script
iamkroot adb513d
Add docs
iamkroot 73bc3ba
Update docs
iamkroot 26c26bd
[autofix.ci] apply automated fixes
autofix-ci[bot] cc06b2c
Don't mark the setting as experimental
iamkroot ff1d977
fix(task): make usage ctx keys snake_case
iamkroot ce6ded1
Update docs
iamkroot c949a5b
Remove disable_spec_from_run_scripts
iamkroot bfd0650
Fix outdated schema
iamkroot b861c6d
[autofix.ci] apply automated fixes
autofix-ci[bot] a46a995
Fix usage in run scripts
iamkroot eb764a6
Add e2e
iamkroot 80cb98f
[autofix.ci] apply automated fixes
autofix-ci[bot] b373c01
Fix flag default
iamkroot 3eae24c
[autofix.ci] apply automated fixes
autofix-ci[bot] 746543b
Update test
iamkroot ea76f0c
Remove bad test
iamkroot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
feat: add experimental option to disable spec collection from run scr…
…ipts Introduced a new setting `task.disable_spec_from_run_scripts` in `settings.toml` to allow users to opt out of parsing task run scripts for usage specifications. When enabled, the usage spec will be derived solely from the `usage` field, ignoring any `arg()`, `option()`, or `flag()` templates in run scripts. This change aims to restore previous behavior and improve performance by avoiding unnecessary template processing. Updated the `TaskScriptParser` to respect this new setting during spec collection, ensuring that the behavior aligns with user preferences. Added tests to verify the functionality of the new option. Related to #6766
- Loading branch information
commit 1ae91b811904f560b474f9df50aee169fc80516e
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.