Skip to content

perf(hook-env): add fast-path to skip initialization when nothing changed #7073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 10 commits into from
Nov 26, 2025
Merged

perf(hook-env): add fast-path to skip initialization when nothing changed #7073

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b1a9171
perf(hook-env): add fast-path to skip initialization when nothing cha…
jdx Nov 26, 2025
8ddd8df
perf(hook-env): fix fast-path detection for config subdirectories
jdx Nov 26, 2025
ecd9921
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 26, 2025
dc82d49
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] Nov 26, 2025
484ec54
fix(hook-env): improve fast-path session detection and e2e test
jdx Nov 26, 2025
7834f94
fix(hook-env): detect deleted data directory in fast-path
jdx Nov 26, 2025
dd1008e
refactor(hook-env): extract mtime_to_millis helper function
jdx Nov 26, 2025
f7738fc
fix(hook-env): handle both --reason=precmd and --reason precmd
jdx Nov 26, 2025
355b9aa
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 26, 2025
bfe3e1d
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[autofix.ci] apply automated fixes (attempt 2/3)
  • Loading branch information
@autofix-ci
autofix-ci[bot] authored Nov 26, 2025
commit dc82d491fe13a39e55b9edbd5d16deeecd1ceb7f
61 changes: 32 additions & 29 deletions src/hook_env.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,41 +110,44 @@ pub fn should_exit_early_fast() -> bool {
// Check if data dir has been modified (new tools installed, etc.)
if dirs::DATA.exists()
&& let Ok(metadata) = dirs::DATA.metadata()
&& let Ok(modified) = metadata.modified() {
let modtime = modified
.duration_since(std::time::SystemTime::UNIX_EPOCH)
.unwrap_or_default()
.as_millis();
if modtime > PREV_SESSION.latest_update {
return false;
}
}
&& let Ok(modified) = metadata.modified()
{
let modtime = modified
.duration_since(std::time::SystemTime::UNIX_EPOCH)
.unwrap_or_default()
.as_millis();
if modtime > PREV_SESSION.latest_update {
return false;
}
}
Copy link

@cursor cursor bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Fast-path misses deleted data directory

The fast-path only checks dirs::DATA modification time when it exists, but skips the check entirely if it doesn't exist. If dirs::DATA existed in the previous session but is now deleted, the fast-path won't detect this change and may incorrectly exit early, leaving stale tool paths in the environment. The check should return false when dirs::DATA is missing to trigger a full environment update.

Fix in Cursor Fix in Web

// Check if any directory in the config search path has been modified
// This catches new config files created anywhere in the hierarchy
if let Some(cwd) = &*dirs::CWD
&& let Ok(ancestor_dirs) = file::all_dirs(cwd, &env::MISE_CEILING_PATHS) {
// Config subdirectories that might contain config files
let config_subdirs = ["", ".config/mise", ".mise", "mise", ".config"];
for dir in ancestor_dirs {
for subdir in &config_subdirs {
let check_dir = if subdir.is_empty() {
dir.clone()
} else {
dir.join(subdir)
};
if let Ok(metadata) = check_dir.metadata()
&& let Ok(modified) = metadata.modified() {
let modtime = modified
.duration_since(std::time::SystemTime::UNIX_EPOCH)
.unwrap_or_default()
.as_millis();
if modtime > PREV_SESSION.latest_update {
return false;
}
}
&& let Ok(ancestor_dirs) = file::all_dirs(cwd, &env::MISE_CEILING_PATHS)
{
// Config subdirectories that might contain config files
let config_subdirs = ["", ".config/mise", ".mise", "mise", ".config"];
for dir in ancestor_dirs {
for subdir in &config_subdirs {
let check_dir = if subdir.is_empty() {
dir.clone()
} else {
dir.join(subdir)
};
if let Ok(metadata) = check_dir.metadata()
&& let Ok(modified) = metadata.modified()
{
let modtime = modified
.duration_since(std::time::SystemTime::UNIX_EPOCH)
.unwrap_or_default()
.as_millis();
if modtime > PREV_SESSION.latest_update {
return false;
}
}
}
}
}
true
}

Expand Down
Loading