-
-
Notifications
You must be signed in to change notification settings - Fork 769
feat(ci): auto-close PRs from non-maintainers #7108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: pr-closer | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: "0 0 * * *" # daily at midnight | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| close-stale-prs: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Close stale PRs | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gh pr list -R jdx/mise --state open --json number,author,labels,createdAt --limit 100 | \ | ||
| jq -r '.[] | select( | ||
| (.createdAt | fromdateiso8601) < (now - 30*24*60*60) and | ||
| .author.login != "jdx" and | ||
| ([.labels[].name] | index("keep-open") | not) | ||
| ) | .number' | \ | ||
| while read -r pr; do | ||
| echo "Closing PR #$pr" | ||
| gh pr close "$pr" -R jdx/mise -c "This PR has been open for more than 30 days without activity. Please reopen if you'd like to continue working on it." | ||
| done | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Closing message claims no activity but code only checks creation date
The workflow filters PRs based on
createdAt(when the PR was first opened) but the closing message states the PR had no "activity". A PR created more than 30 days ago could have had recent commits or comments, yet would still be closed with a misleading message claiming lack of activity. Either the filter needs to useupdatedAtto actually check for recent activity, or the closing message needs to accurately reflect that closure is based on creation date, not activity.