fix(ui): remove duplicate 'mise' prefix in verbose footer output #7174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VerboseReport uses log::info! which already adds a "mise" prefix via the logger. The footer_text was also including "mise", resulting in "mise mise 2025.12.0-DEBUG by @jdx" in verbose output. Move the "mise" prefix to only be included for progress bar overlay where it's needed, and use just the version text for VerboseReport. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes duplicate "mise" prefix in verbose footer output by removing the prefix from the text passed to VerboseReport, since the logger already adds it.
Key changes:
- Extract version text into a shared variable to avoid duplication
- Use version text with "mise" prefix for progress bar overlay
- Use version text without "mise" prefix for VerboseReport (logger adds it automatically)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.11.11 x -- echo |
18.5 ± 0.4 | 17.8 | 22.7 | 1.00 |
mise x -- echo |
18.8 ± 0.6 | 18.0 | 25.7 | 1.02 ± 0.04 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.11.11 env |
17.9 ± 0.3 | 17.3 | 19.0 | 1.00 |
mise env |
18.7 ± 12.6 | 17.5 | 299.8 | 1.04 ± 0.70 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.11.11 hook-env |
18.0 ± 0.3 | 17.4 | 20.3 | 1.00 |
mise hook-env |
18.2 ± 0.3 | 17.7 | 20.1 | 1.01 ± 0.03 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.11.11 ls |
15.6 ± 0.3 | 15.0 | 16.9 | 1.00 |
mise ls |
15.7 ± 0.4 | 15.1 | 19.0 | 1.01 ± 0.03 |
xtasks/test/perf
| Command | mise-2025.11.11 | mise | Variance |
|---|---|---|---|
| install (cached) | 105ms | 105ms | +0% |
| ls (cached) | 64ms | 64ms | +0% |
| bin-paths (cached) | 72ms | 70ms | +2% |
| task-ls (cached) | 429ms | 420ms | +2% |
jdx
pushed a commit
that referenced
this pull request
Dec 4, 2025
### 🚀 Features - **(config)** add support for netrc by @RobotSupervisor in [#7164](#7164) - **(lock)** add resolve_lock_info to core backends for checksum fetching by @jdx in [#7180](#7180) - **(ruby)** Install ruby from a zip file over HTTPS by @KaanYT in [#7167](#7167) - **(tasks)** add `usage` args to Tera context in run scripts by @iamkroot in [#7041](#7041) ### 🐛 Bug Fixes - **(lock)** validate platform qualifiers when reading from lockfile by @jdx in [#7181](#7181) - **(task)** retry shebang scripts on ETXTBUSY by @iamkroot in [#7162](#7162) - **(ui)** remove duplicate 'mise' prefix in verbose footer output by @jdx in [#7174](#7174) ### 📦️ Dependency Updates - bump usage-lib to 2.9.0 by @jdx in [#7177](#7177) ### 📦 Registry - remove duplicated ubi and github backends from gping by @risu729 in [#7144](#7144) - disable bashly test (not working in CI) by @jdx in [#7173](#7173) - disable cfn-lint test (failing in CI) by @jdx in [#7176](#7176) ### Chore - add fd to mise.toml by @blampe in [#7178](#7178) ### New Contributors - @RobotSupervisor made their first contribution in [#7164](#7164) ## 📦 Aqua Registry Updates #### New Packages (2) - [`Kitware/CMake`](https://github.com/Kitware/CMake) - [`quarto-dev/quarto-cli`](https://github.com/quarto-dev/quarto-cli) #### Updated Packages (6) - [`apache/jena`](https://github.com/apache/jena) - [`apache/spark`](https://github.com/apache/spark) - [`danielfoehrKn/kubeswitch`](https://github.com/danielfoehrKn/kubeswitch) - [`danielfoehrKn/kubeswitch/switch-sh`](https://github.com/danielfoehrKn/kubeswitch/switch-sh) - [`evilmartians/lefthook`](https://github.com/evilmartians/lefthook) - [`updatecli/updatecli`](https://github.com/updatecli/updatecli)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
log::info!which already adds "mise" via the logger, so remove it from the footer text passed to VerboseReportTest plan
mise installwith--verboseflag and verify output showsmise 2025.12.0 by @jdxinstead ofmise mise 2025.12.0 by @jdx🤖 Generated with Claude Code
Note
Avoid duplicate "mise" in verbose footer by excluding the prefix for VerboseReport while keeping the full "mise VERSION by @jdx" overlay for progress bars.
version_text("{version} by @jdx") for verbose mode to prevent duplicate "mise" since logger already prefixes."mise {version_text}".Written by Cursor Bugbot for commit 3165cba. This will update automatically on new commits. Configure here.