Skip to content

python3 support and improved tests #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

python3 support and improved tests #95

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
17df510
Python3 support. Passes tests but they need to be updated to call
Jwink3101 Sep 12, 2019
1497462
Added test runner but need to fix failed test
Jwink3101 Sep 12, 2019
89cc532
Fixed issue with python2. Issue with instance check for unicode
Jwink3101 Sep 12, 2019
2f6c8c6
Readded the 2.6 backport but I can't get this OR the original to run …
Jwink3101 Sep 12, 2019
6bc3ef8
Added retro test and fixed other
Jwink3101 Sep 12, 2019
566e505
minor cleanup and changed back shebang from debugging
Jwink3101 Sep 12, 2019
06477f3
Tests on an actual binary file
Jwink3101 Sep 18, 2019
c756f1b
Changed one of the files to be random bytes to make sure we're encoding
Jwink3101 Sep 18, 2019
87ba622
Take II at python3 conversion
Jwink3101 Sep 18, 2019
773879f
one more fix
Jwink3101 Oct 8, 2019
96c95b0
uncommented out section
Jwink3101 Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed issue with python2. Issue with instance check for unicode
  • Loading branch information
@Jwink3101
Jwink3101 committed Sep 12, 2019
commit 89cc532b6e5e75b79ccd38d77e227d082c9fd44d
4 changes: 2 additions & 2 deletions git-fat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ class GitFat(object):
digest, bytes = self.decode_stream(open(fname))
except IOError:
return False, None
if isinstance(digest, str):
if isinstance(digest, (str,unicode)):
return digest, bytes
else:
return None, bytes
Expand Down Expand Up @@ -269,7 +269,7 @@ class GitFat(object):
def cmd_filter_smudge(self):
self.setup()
result, bytes = self.decode_stream(sys.stdin)
if isinstance(result, str): # We got a digest
if isinstance(result, (str,unicode)): # We got a digest
objfile = os.path.join(self.objdir, result)
try:
cat(open(objfile), sys.stdout)
Expand Down