Skip to content

Conversation

@jeertmans
Copy link
Owner

This is a complete rewrite of the manim-slides present player with two main objectives:

  • make it run as fast as possible, by using already existing tools from PySide6, and minimizing the amount of Python code;
  • reducing the code complexity, for better maintainability.

Read the changelog file for more details.

@jeertmans jeertmans added cli Related to the command line interface enhancement New feature or request present Related to the main "present" feature labels Aug 21, 2023
@jeertmans jeertmans temporarily deployed to github-pages August 21, 2023 12:52 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 73.20% and project coverage change: +4.28% 🎉

Comparison is base (b321161) 63.25% compared to head (d0f0d11) 67.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   63.25%   67.53%   +4.28%     
==========================================
  Files          15       16       +1     
  Lines        1682     1491     -191     
==========================================
- Hits         1064     1007      -57     
+ Misses        618      484     -134     
Files Changed Coverage Δ
manim_slides/wizard.py 37.39% <0.00%> (ø)
manim_slides/present/__init__.py 61.60% <61.60%> (ø)
manim_slides/present/player.py 76.62% <76.62%> (ø)
manim_slides/config.py 83.91% <88.37%> (-0.59%) ⬇️
manim_slides/convert.py 74.19% <100.00%> (ø)
manim_slides/slide.py 85.38% <100.00%> (+0.49%) ⬆️
manim_slides/utils.py 91.89% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans jeertmans temporarily deployed to github-pages August 21, 2023 14:37 — with GitHub Actions Inactive
@jeertmans jeertmans merged commit 638616c into main Aug 21, 2023
@jeertmans jeertmans deleted the rewrite-player branch August 21, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Related to the command line interface enhancement New feature or request present Related to the main "present" feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants