Skip to content

fix(cli/convert): ensure dest path can be written #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix(cli/convert): ensure dest path can be written #262

merged 2 commits into from
Sep 15, 2023

Conversation

@jeertmans
Copy link
Owner

@jeertmans jeertmans commented Aug 31, 2023

Fixes the issue that non-existing parent(s) in the dest path would raise an error.

@jeertmans
fix(cli/convert): ensure dest path can be written
7df79f7 
Fixes the issue that non-existing parent(s) in the dest path would raise an error.
@jeertmans jeertmans added bug Something isn't working cli Related to the command line interface labels Aug 31, 2023
@jeertmans jeertmans temporarily deployed to github-pages August 31, 2023 14:02 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage is 33.33% of modified lines.

Files Changed Coverage
manim_slides/convert.py 33.33%

📢 Thoughts on this report? Let us know!.

@jeertmans jeertmans merged commit 6272d3f into main Sep 15, 2023
@jeertmans jeertmans deleted the fix-path-does-not-exist branch September 15, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working cli Related to the command line interface

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeertmans