Skip to content

refactor(lib): change how manim API is imported #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Oct 17, 2023
Merged

refactor(lib): change how manim API is imported #285

merged 38 commits into from
Oct 17, 2023

Conversation

@jeertmans
Copy link
Owner

@jeertmans jeertmans commented Oct 13, 2023

No description provided.

@jeertmans jeertmans added the lib Related to the library (a.k.a. module) label Oct 13, 2023
github-actions[bot]
github-actions bot reviewed Oct 13, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Files Coverage Δ
manim_slides/__main__.py 71.42% <100.00%> (-0.67%) ⬇️
manim_slides/config.py 83.91% <ø> (ø)
manim_slides/convert.py 74.18% <ø> (ø)
manim_slides/docs/manim_slides_directive.py 0.00% <ø> (ø)
manim_slides/logger.py 100.00% <100.00%> (ø)
manim_slides/slide/manimlib.py 100.00% <100.00%> (ø)
manim_slides/wizard.py 37.39% <ø> (ø)
manim_slides/slide/animation.py 96.55% <96.55%> (ø)
manim_slides/utils.py 89.74% <83.33%> (-2.15%) ⬇️
manim_slides/slide/manim.py 93.47% <93.47%> (ø)
... and 2 more

📢 Thoughts on this report? Let us know!.

@jeertmans jeertmans temporarily deployed to github-pages October 17, 2023 10:01 — with GitHub Actions Inactive
@jeertmans jeertmans temporarily deployed to github-pages October 17, 2023 10:37 — with GitHub Actions Inactive
This was linked to issues Oct 17, 2023
[BUG] Calling self.wipe does not work with ManimGL #265
Closed
[FEATURE] make self.wipe and self.zoom classes instead of methods #267
Closed
[BUG] no attribute 'frame_width' #278
Closed
@pre-commit-ci pre-commit-ci bot temporarily deployed to github-pages October 17, 2023 10:53 Inactive
@jeertmans jeertmans temporarily deployed to github-pages October 17, 2023 11:09 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to github-pages October 17, 2023 13:49 Inactive
@jeertmans jeertmans merged commit 802f640 into main Oct 17, 2023
@jeertmans jeertmans deleted the refactor-manim branch October 17, 2023 14:06
@jeertmans jeertmans mentioned this pull request Oct 17, 2023
Closed
4 tasks
@jeertmans jeertmans linked an issue Oct 17, 2023 that may be closed by this pull request
[TEST] Properly test ManimGL support #276
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

lib Related to the library (a.k.a. module)

Projects

None yet

Milestone

No milestone

2 participants

@jeertmans