Skip to content

chore(ci): enhance current lint rules #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 18, 2023
Merged

chore(ci): enhance current lint rules #289

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
529650a
chore(ci): enhance current lint rules
jeertmans Oct 18, 2023
2888692
run linter
jeertmans Oct 18, 2023
a7e7ede
fix all warnings
jeertmans Oct 18, 2023
829d285
fix(convert): release VideoCapture
jeertmans Oct 18, 2023
7bcde6f
fix(ci): properly close file
jeertmans Oct 18, 2023
9143c60
better tests
jeertmans Oct 18, 2023
a33f53a
fix(ci): setup opengl
jeertmans Oct 18, 2023
6b92cf0
Revert "fix(ci): setup opengl"
jeertmans Oct 18, 2023
57da2d4
fix(ci): skipif Windows in workflows
jeertmans Oct 18, 2023
944dc8c
actually xfail
jeertmans Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(convert): release VideoCapture
  • Loading branch information
@jeertmans
jeertmans authored Oct 18, 2023
commit 829d28534600bab1255e48008ee81be3b5bd71d5
2 changes: 2 additions & 0 deletions manim_slides/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,7 @@ def read_image_from_video_file(file: Path, frame_index: FrameIndex) -> Image:
cap.set(cv2.CAP_PROP_POS_FRAMES, index - 1)

ret, frame = cap.read()
cap.release()

if ret:
frame = cv2.cvtColor(frame, cv2.COLOR_BGR2RGB)
Expand Down Expand Up @@ -495,6 +496,7 @@ def xpath(el: etree.Element, query: str) -> etree.XPath:
def save_first_image_from_video_file(file: Path) -> Optional[str]:
cap = cv2.VideoCapture(file.as_posix())
ret, frame = cap.read()
cap.release()

if ret:
f = tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".png")
Expand Down