Skip to content

Fix the issue of blurry media images in notifications. - #1493

Merged
Maxr1998 merged 2 commits into
jellyfin:masterfrom
peerless2012:fix_notification_art
Jan 25, 2025
Merged

Fix the issue of blurry media images in notifications.#1493
Maxr1998 merged 2 commits into
jellyfin:masterfrom
peerless2012:fix_notification_art

Conversation

@peerless2012

Copy link
Copy Markdown
Contributor

Changes
Use MediaMetadata art to override large icon in notification, fix art not clear issue.

Before:
微信截图_20241011232259

After:
微信截图_20241011232400

@jellyfin-bot jellyfin-bot added this to the v2.7.0 milestone Oct 11, 2024
@peerless2012

Copy link
Copy Markdown
Contributor Author

The notification art is land, maybe use backdrop art resource?

@Maxr1998 Maxr1998 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR and bringing this issue to my attention. I'd argue that setting the metadata in the notification helper isn't the best location, but it is good enough for now.

I realized that the artwork loading can generally be improved by implementing a content provider, but this is out of scope for this PR.

Thus, I'll merge it as is. Thanks again!

@Maxr1998
Maxr1998 merged commit bec1680 into jellyfin:master Jan 25, 2025
@peerless2012
peerless2012 deleted the fix_notification_art branch January 26, 2025 01:27
@nielsvanvelzen nielsvanvelzen added bug Something isn't working backport Pull request needs to be backported to current release branch labels May 8, 2025
@nielsvanvelzen nielsvanvelzen modified the milestones: v2.7.0, v2.6.3 May 9, 2025
@nielsvanvelzen nielsvanvelzen removed the backport Pull request needs to be backported to current release branch label May 9, 2025
nielsvanvelzen pushed a commit that referenced this pull request May 9, 2025
@pavichokche

Copy link
Copy Markdown

I updated to the 2.6.3-beta1 but I'm still seeing blurry images in the notification. I cleared the app cache and it's still the same. Android 15 Samsung S25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants