Dynamically query device H264 max level for WebView device profile - #1956
Merged
nielsvanvelzen merged 1 commit intoJun 12, 2026
Merged
Conversation
stumpylog
force-pushed
the
fix/dynamic-codec-capabilities
branch
from
April 17, 2026 22:13
34720e6 to
0c4918a
Compare
stumpylog
marked this pull request as ready for review
April 17, 2026 22:13
nielsvanvelzen
approved these changes
Jun 12, 2026
Member
|
Please rebase the PR so the CI can run |
Instead of hardcoding H264 level "41" in nativeshell.js, query the actual device max AVC level at runtime via NativeInterface.getCodecCapabilities(). This lets devices that support H264 level 4.2, 5.0, etc. direct-play content that was previously forced to transcode. The profile list (high/main/baseline/constrained baseline) is left hardcoded deliberately: Chromium's <video> pipeline in the WebView does not decode the full set of H264 profiles MediaCodec advertises (notably 10-bit), so advertising them would risk regressions. Fixes jellyfin#1921 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
stumpylog
force-pushed
the
fix/dynamic-codec-capabilities
branch
from
June 12, 2026 18:12
0c4918a to
9f296d2
Compare
Contributor
Author
|
Done! |
|
Awesome, great to see! Any estimate on when this will make it to the deployed Google Play store app? Or if we want to test/see this in action we'd have to manually build APK from this repo? |
Member
|
Will be part of 2.7.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This is an attempt, using Claude, to resolve the linked issue. Instead of hardcoding the maximum H264 level, build it dynamically for the WebView. This should allow clients which support higher levels to not transcode.
I confirmed with a level 4.2 file on my Pixel 6 Pro. Using the web player, the current release results in transcoding. With a build from this branch, the file is direct played. I was able to reach level 5.2, the maximum my device supports, before transcoding began again.
Issues
Fixes #1921