Support voice controlled playback on Android Auto - #2059
Merged
Conversation
| // Play via search | ||
| firstItem.mediaId == MediaItem.DEFAULT_MEDIA_ID && firstItem.requestMetadata.mediaUri == null -> { | ||
| val search = firstItem.requestMetadata.searchQuery | ||
| Timber.d("Search requested $search") |
| val search = firstItem.requestMetadata.searchQuery | ||
| Timber.d("Search requested $search") | ||
|
|
||
| val route = if (search.isNullOrEmpty()) LibraryRoute.Suggested |
| Timber.d("Search requested $search") | ||
|
|
||
| val route = if (search.isNullOrEmpty()) LibraryRoute.Suggested | ||
| else LibraryRoute.Search(search) |
thornbill
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Google rejected our app because we did not implement a feature that is hidden away in their terrible API design. When
onSetMediaItemsis called with a single item that has a search query set in its request metadata it means that Android Auto voice control was used to playback music, we need to parse the query and create the actual item playlist. This is the most dumb API design I've seen so far from Google.This PR implements that stupid behavior and uses either the suggested item page if the query is empty or the search page when searching for specific items.
Ideally we'd implement the search without the route as that returns items in sections and not necessarily the most relevant item first. I couldn't be bothered to do it the proper way though.
Code assistance
Issues