-
Notifications
You must be signed in to change notification settings - Fork 76
Fix secondary promise timeouts #1237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
5a4d908
to
03f727f
Compare
This commit addresses several critical issues in the OpenHIM routing system: 1. Fixed socket hangup errors by creating fresh connection agents for each request 2. Resolved timeout issues by extending server socket timeouts and improving promise handling 3. Added support for Brotli compression to handle all content encoding types 4. Implemented robust error handling for secondary routes to prevent transaction failures 5. Fixed duplicate requests by removing problematic await statements and properly chaining promises 6. Added comprehensive logging for better diagnostics and troubleshooting 7. Improved secondary route processing to ensure transactions complete even when routes fail These changes significantly improve the reliability of the routing system, particularly for secondary routes that depend on primary route responses.
03f727f
to
490aa1a
Compare
9576f39
to
661593e
Compare
fix: resolve HTTP request timeouts and connection issues
This commit addresses several critical issues in the OpenHIM routing system:
These changes significantly improve the reliability of the routing system,
particularly for secondary routes that depend on primary route responses.