Skip to content

Conversation

@froque
Copy link
Member

@froque froque commented Sep 6, 2023

This is no longer being thrown by Crontab constructor

jenkinsci/jenkins#7293

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] ~~Link to relevant issues in GitHub or Jira~~
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] ~~Ensure you have provided tests - that demonstrates feature works or fixes the issue~~

This is no longer being thrown by Crontab constructor
jenkinsci/jenkins#7293
@froque froque merged commit 67eabc4 into master Sep 6, 2023
@froque froque deleted the remove_ANTLRException branch September 6, 2023 17:02
}
return time;

} catch (ANTLRException ex) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To preserve existing behavior, should catch IllegalArgumentException instead of ANTLRException.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants