Skip to content

Resolve 2 spotbugs issues and increase spotbugs checks #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkEWaite merged 12 commits into from
Feb 11, 2023
Merged

Resolve 2 spotbugs issues and increase spotbugs checks #100

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
520c069
Deeper spotbugs checks
prince-panwar Feb 9, 2023
dfe0019
Update pom.xml
prince-panwar Feb 9, 2023
030b389
resolved 3 bugs spotted by spotbugs
prince-panwar Feb 10, 2023
aa0e0c6
spotbugs exclusin file added
prince-panwar Feb 10, 2023
0b32055
Set checkstyle plugin version
MarkEWaite Feb 10, 2023
e42bc19
Use Class, Field, and Method in spotbugs exclusions
MarkEWaite Feb 10, 2023
b7510e7
Finish undo of GitLabSecurityRealm change
MarkEWaite Feb 10, 2023
5d7ec6e
Use consistent indentation in spotbugs properties
MarkEWaite Feb 10, 2023
724f655
Indent GitLabAuthenticationToken change consistently
MarkEWaite Feb 10, 2023
b8e5404
Undo GitLabOAuthUserDetails unexpected change
MarkEWaite Feb 10, 2023
b2b71a2
Replaced hard-coded value for user constructor
prince-panwar Feb 11, 2023
984327f
Revert "Replaced hard-coded value for user constructor"
prince-panwar Feb 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Class, Field, and Method in spotbugs exclusions
  • Loading branch information
@MarkEWaite
MarkEWaite committed Feb 10, 2023
commit e42bc192edf2b5d2ccc518bf7ea84d66034a3f80
30 changes: 14 additions & 16 deletions src/spotbugs/excludesFilter.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,18 @@
exclusion from this section.
-->
<Match>
<Or>
<And>
<Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED"/>
<Class name="org.jenkinsci.plugins.GitLabAuthenticationToken.gitLabAPI"/>
</And>
<And>
<Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED"/>
<Class name="org.jenkinsci.plugins.GitLabAuthenticationToken.me"/>
</And>
<And>
<Bug pattern="DM_CONVERT_CASE"/>
<Class name="org.jenkinsci.plugins.GitLabSecurityRealm$ConverterImpl.setValue"/>
</And>

</Or>
<Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED"/>
<Class name="org.jenkinsci.plugins.GitLabAuthenticationToken"/>
<Field name="gitLabAPI"/>
</Match>
</FindBugsFilter>
<Match>
<Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED"/>
<Class name="org.jenkinsci.plugins.GitLabAuthenticationToken"/>
<Field name="me"/>
</Match>
<Match>
<Bug pattern="DM_CONVERT_CASE"/>
<Class name="org.jenkinsci.plugins.GitLabSecurityRealm$ConverterImpl"/>
<Method name="setValue"/>
</Match>
</FindBugsFilter>