Skip to content

Conversation

@zhangethan
Copy link
Contributor

it's not compatible with gitlab-ce 12.5, gitlab will return 401 when trying to get access_token.

Testing done

I tested it with gitlab 12.5 and 16.1

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

it's not compatible with gitlab-ce 12.5, gitlab will return 401 when trying to get access_token.
@zhangethan zhangethan requested a review from a team as a code owner July 13, 2023 08:35
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks reasonable to me, since the parameters list is empty, the URL encoded format will be empty as well.

I don't think that it is especially important to support GitLab 12, since GitLab has issued many security advisories for versions after it and is not providing security fixes for GitLab 12.

@krisstern
Copy link
Member

Thanks @zhangethan for your contribution!

@krisstern krisstern merged commit d6a226f into jenkinsci:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants