Skip to content

Don't include /etc/apt/sources.list.d/jenkins.list in dpkg#170

Closed
twpayne wants to merge 1 commit into
jenkinsci:masterfrom
twpayne:dont-include-apt-sources.list-in-dpkg
Closed

Don't include /etc/apt/sources.list.d/jenkins.list in dpkg#170
twpayne wants to merge 1 commit into
jenkinsci:masterfrom
twpayne:dont-include-apt-sources.list-in-dpkg

Conversation

@twpayne
Copy link
Copy Markdown
Contributor

@twpayne twpayne commented Jun 21, 2011

The attached patch removes /etc/apt/sources.lists.d/jenkins.list from the Debian package.

The presence of jenkins.list prevents the sysadmin from controlling the updating of the Jenkins package. For example, it:

  • bypasses any local apt mirror
  • causes problems for apt-get update on machines without external internet access (e.g. intranet build clusters)

jenkins.list should be distributed separately from the package.

Regards,
Tom

@resmo
Copy link
Copy Markdown
Contributor

resmo commented Jun 23, 2011

+1

@kohsuke
Copy link
Copy Markdown
Member

kohsuke commented Jun 24, 2011

Given two +1s, I'll merge them (plus our http://pkg.jenkins-ci.org/debian/ tells users to add it manually), but I was doing this partly because I noticed that other packages seem to be doing it.

I wonder if there's some official debian policies around this.

@kohsuke
Copy link
Copy Markdown
Member

kohsuke commented Jun 24, 2011

Merged toward 1.419.

@kohsuke kohsuke closed this Jun 24, 2011
@twpayne
Copy link
Copy Markdown
Contributor Author

twpayne commented Jun 27, 2011

Many thanks for merging the patch.

I did search the Debian policy documents before making the pull request, but I could not find anything relating to this.

Regards,
Tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants