Minor improvements to Mac installer#188
Closed
stisti wants to merge 4 commits into
Closed
Conversation
The Jenkins launch daemon is configured "RunAtLoad", i.e. it runs immediately. No need to start it.
Files under /Applications are usually owned by root and wheel, unless admin user has dragged it there. Jenkins is not an install-by-dragging kind of app.
Although there aren't any Jenkins packages deployed that use a launch daemon, soon there will be. Let's make the preinstall capable of handling that already now.
Member
|
Thanks! Merged toward 1.421. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to submit these patches to be considered for merging into Jenkins. These patches change file owners and permissions to be more in line with Mac conventions. Also, the launch daemon config file should be reloaded on upgrades.