Skip to content

Memory options for windows service#328

Closed
Vlatombe wants to merge 2 commits into
jenkinsci:masterfrom
Vlatombe:memory-options-for-windows-service
Closed

Memory options for windows service#328
Vlatombe wants to merge 2 commits into
jenkinsci:masterfrom
Vlatombe:memory-options-for-windows-service

Conversation

@Vlatombe
Copy link
Copy Markdown
Member

Some additional enhancements to the managed slaves using windows services :

  • When disconnecting a slave, there was still an issue with the 'host' used
  • Disconnecting the slave now removes the service. This allows to re-register the service using the right credentials if they have been changed after the first connection
  • Memory options have been added to the slave configuration (similar to jnlp, we may need to customize the java options)
  • In case memory settings have been modified, disconnecting then reconnecting the slave copies jenkins-slave.xml with the updated configuration
  • Some minor improvement on the expand logic on radioBlocks.

- Loop only on tags between block-start and block-end
- Clearer and shorter code
- 3 options : run as Local System, Administrator or custom account
- Memory options
- Disconnect the slaves stops correctly and deletes the service
- Reconnecting the slave updates the jenkins-slave.xml configuration
@kohsuke
Copy link
Copy Markdown
Member

kohsuke commented Jan 3, 2012

working on this now.

@kohsuke
Copy link
Copy Markdown
Member

kohsuke commented Jan 3, 2012

I've somwhat modified the change but merged this toward 1.448.

@kohsuke kohsuke closed this Jan 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants