Mailer removed from core#629
Merged
Merged
Conversation
Member
|
The one problem I saw when I was originally looking at this is that the Mailer is what provides the Jenkins URL to other areas, even in the core. I didn't see changes to work around this in the files. |
Member
Author
|
I understand that this is more of a nasty hack than a solution one can be proud of, but since it is a bundled plugin I dare to say it will work. I guess several properties* (including jenkinsUrl) can be moved back to the core as suggested by Jesse Glick. |
Member
|
Thanks for doing this! This is an awesome awesome change. To make this really work properly without breaking compatibility with earlier plugins, I added 5237146 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes mailer functionality from core and bundles in org.jenkins-ci.plugins:mailer in version 1.2.
Only files really modified are:
pom.xml
test/pom.xml
war/pom.xml