Skip to content

Mailer removed from core#629

Merged
kohsuke merged 1 commit into
jenkinsci:masterfrom
olivergondza:no-mailer
Dec 9, 2012
Merged

Mailer removed from core#629
kohsuke merged 1 commit into
jenkinsci:masterfrom
olivergondza:no-mailer

Conversation

@olivergondza
Copy link
Copy Markdown
Member

This commit removes mailer functionality from core and bundles in org.jenkins-ci.plugins:mailer in version 1.2.

Only files really modified are:
pom.xml
test/pom.xml
war/pom.xml

@slide
Copy link
Copy Markdown
Member

slide commented Nov 27, 2012

The one problem I saw when I was originally looking at this is that the Mailer is what provides the Jenkins URL to other areas, even in the core. I didn't see changes to work around this in the files.

@olivergondza
Copy link
Copy Markdown
Member Author

I understand that this is more of a nasty hack than a solution one can be proud of, but since it is a bundled plugin I dare to say it will work.

I guess several properties* (including jenkinsUrl) can be moved back to the core as suggested by Jesse Glick.

@kohsuke kohsuke merged commit fd3ee4a into jenkinsci:master Dec 9, 2012
@kohsuke
Copy link
Copy Markdown
Member

kohsuke commented Dec 9, 2012

Thanks for doing this! This is an awesome awesome change.

To make this really work properly without breaking compatibility with earlier plugins, I added 5237146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants