[JENKINS-68652] Update ANTLR2 to ANTLR4

bom/pom.xml

@@ -68,11 +68,6 @@ THE SOFTWARE.
         <type>pom</type>
         <scope>import</scope>
       </dependency>
-      <dependency>
-        <groupId>antlr</groupId>
-        <artifactId>antlr</artifactId>
-        <version>2.7.7</version>
-      </dependency>
       <dependency>
         <!-- JENKINS-21160: Remoting also depends on args4j; please update accordingly -->
         <groupId>args4j</groupId>
@@ -190,6 +185,11 @@ THE SOFTWARE.
         <artifactId>kxml2</artifactId>
         <version>2.3.0</version>
       </dependency>
+      <dependency>
+        <groupId>org.antlr</groupId>
+        <artifactId>antlr4-runtime</artifactId>
+        <version>${antlr.version}</version>
+      </dependency>
       <dependency>
         <groupId>org.apache.ant</groupId>
         <artifactId>ant</artifactId>

core/pom.xml

@@ -67,10 +67,6 @@ THE SOFTWARE.
       <groupId>${project.groupId}</groupId>
       <artifactId>remoting</artifactId>
     </dependency>
-    <dependency>
-      <groupId>antlr</groupId>
-      <artifactId>antlr</artifactId>
-    </dependency>
     <dependency>
       <groupId>args4j</groupId>
       <artifactId>args4j</artifactId>
@@ -278,6 +274,10 @@ THE SOFTWARE.
       <groupId>net.sf.kxml</groupId>
       <artifactId>kxml2</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.antlr</groupId>
+      <artifactId>antlr4-runtime</artifactId>
+    </dependency>
     <dependency>
       <groupId>org.apache.ant</groupId>
       <artifactId>ant</artifactId>
@@ -571,7 +571,6 @@ THE SOFTWARE.
             <phase>generate-sources</phase>
             <configuration>
               <sources>
-                <source>${project.build.directory}/generated-sources/antlr</source>
                 <source>${project.build.directory}/generated-sources/localizer</source>
                 <source>${project.build.directory}/generated-sources/taglib-interface</source>
               </sources>
@@ -632,29 +631,15 @@ THE SOFTWARE.
         </executions>
       </plugin>
       <plugin>
-        <groupId>org.codehaus.mojo</groupId>
-        <artifactId>antlr-maven-plugin</artifactId>
+        <groupId>org.antlr</groupId>
+        <artifactId>antlr4-maven-plugin</artifactId>
         <!-- version specified in grandparent pom -->
         <executions>
           <execution>
-            <id>cron</id>
+            <id>antlr</id>
             <goals>
-              <goal>generate</goal>
+              <goal>antlr4</goal>
             </goals>
-            <configuration>
-              <sourceDirectory>${basedir}/src/main/grammar</sourceDirectory>
-              <grammars>crontab.g</grammars>
-            </configuration>
-          </execution>
-          <execution>
-            <id>labelExpr</id>
-            <goals>
-              <goal>generate</goal>
-            </goals>
-            <configuration>
-              <sourceDirectory>${basedir}/src/main/grammar</sourceDirectory>
-              <grammars>labelExpr.g</grammars>
-            </configuration>
           </execution>
         </executions>
       </plugin>

core/src/main/antlr4/hudson/model/labels/LabelExpressionLexer.g4

@@ -0,0 +1,57 @@
+lexer grammar LabelExpressionLexer;
+
+AND
+   : '&&'
+   ;
+
+OR
+   : '||'
+   ;
+
+NOT
+   : '!'
+   ;
+
+IMPLIES
+   : '->'
+   ;
+
+IFF
+   : '<->'
+   ;
+
+LPAREN
+   : '('
+   ;
+
+RPAREN
+   : ')'
+   ;
+
+fragment IDENTIFIER_PART
+   : ~ ('&' | '|' | '!' | '<' | '>' | '(' | ')' | ' ' | '\t' | '"' | '\'' | '-')
+   ;
+
+ATOM
+/*
+    the real check of valid identifier happens in LabelAtom.get()
+
+    https://www.antlr2.org/doc/lexer.html#usingexplicit
+    If we are seeing currently a '-', we check that the next char is not a '>' which will be a IMPLIES.
+    Otherwise the ATOM and the IMPLIES will collide and expr like a->b will just be parsed as ATOM (without spaces)
+*/
+
+   : (
+   { _input.LA(2) != '>' }? '-' | IDENTIFIER_PART)+
+   ;
+
+WS
+   : (' ' | '\t')+ -> skip
+   ;
+
+STRINGLITERAL
+   : '"' ('\\' ('b' | 't' | 'n' | 'f' | 'r' | '"' | '\'' | '\\') /* escape */
+
+   | ~ ('\\' | '"' | '\r' | '\n'))* '"'
+   ;
+

core/src/main/antlr4/hudson/model/labels/LabelExpressionParser.g4

@@ -0,0 +1,56 @@
+parser grammar LabelExpressionParser;
+
+@ header
+{
+import hudson.model.Label;
+}
+
+options { tokenVocab = LabelExpressionLexer; }
+// order of precedence is as per http://en.wikipedia.org/wiki/Logical_connective#Order_of_precedence
+
+expr returns[Label l]
+   : term1
+   { $l=$term1.ctx.l; } EOF
+   ;
+
+term1 returns[Label l] locals[Label r]
+   : term2
+   { $l=$term2.ctx.l; } (IFF term2
+   { $r=$term2.ctx.l; $l=$l.iff($r); })*
+   ;
+   // (a->b)->c != a->(b->c) (for example in case of a=F,b=T,c=F) so don't allow chaining
+
+term2 returns[Label l] locals[Label r]
+   : term3
+   { $l=$term3.ctx.l; } (IMPLIES term3
+   { $r=$term3.ctx.l; $l=$l.implies($r); })?
+   ;
+
+term3 returns[Label l] locals[Label r]
+   : term4
+   { $l=$term4.ctx.l; } (OR term4
+   { $r=$term4.ctx.l; $l=$l.or($r); })*
+   ;
+
+term4 returns[Label l] locals[Label r]
+   : term5
+   { $l=$term5.ctx.l; } (AND term5
+   { $r=$term5.ctx.l; $l=$l.and($r); })*
+   ;
+
+term5 returns[Label l]
+   : term6
+   { $l=$term6.ctx.l; }
+   | NOT term6
+   { $l=$term6.ctx.l; $l=$l.not(); }
+   ;
+
+term6 returns[Label l]
+   : LPAREN term1 RPAREN
+   { $l=$term1.ctx.l ; $l=$l.paren(); }
+   | ATOM
+   { $l=LabelAtom.get($ATOM.getText()); }
+   | STRINGLITERAL
+   { $l=LabelAtom.get(hudson.util.QuotedStringTokenizer.unquote($STRINGLITERAL.getText())); }
+   ;
+

core/src/main/antlr4/hudson/scheduler/CrontabLexer.g4

@@ -0,0 +1,70 @@
+lexer grammar CrontabLexer;
+
+TOKEN
+   : ('0' .. '9')+
+   ;
+
+WS
+   : (' ' | '\t')+
+   ;
+
+MINUS
+   : '-'
+   ;
+
+STAR
+   : '*'
+   ;
+
+DIV
+   : '/'
+   ;
+
+OR
+   : ','
+   ;
+
+AT
+   : '@'
+   ;
+
+H
+   : 'H'
+   ;
+
+LPAREN
+   : '('
+   ;
+
+RPAREN
+   : ')'
+   ;
+
+YEARLY
+   : 'yearly'
+   ;
+
+ANNUALLY
+   : 'annually'
+   ;
+
+MONTHLY
+   : 'monthly'
+   ;
+
+WEEKLY
+   : 'weekly'
+   ;
+
+DAILY
+   : 'daily'
+   ;
+
+MIDNIGHT
+   : 'midnight'
+   ;
+
+HOURLY
+   : 'hourly'
+   ;
+

core/src/main/antlr4/hudson/scheduler/CrontabParser.g4

@@ -0,0 +1,83 @@
+parser grammar CrontabParser;
+
+
+options { tokenVocab = CrontabLexer; superClass = BaseParser; }
+startRule[CronTab table]
+   : expr[0]
+   { $table.bits[0]=$expr.ctx.bits; } WS expr[1]
+   { $table.bits[1]=$expr.ctx.bits; } WS expr[2]
+   { $table.bits[2]=$expr.ctx.bits; } WS expr[3]
+   { $table.bits[3]=$expr.ctx.bits; } WS expr[4]
+   { $table.dayOfWeek=(int)$expr.ctx.bits; } EOF
+   | (AT ('yearly'
+   {
+           $table.set("H H H H *",getHashForTokens());
+         } | 'annually'
+   {
+           $table.set("H H H H *",getHashForTokens());
+         } | 'monthly'
+   {
+           $table.set("H H H * *",getHashForTokens());
+         } | 'weekly'
+   {
+           $table.set("H H * * H",getHashForTokens());
+         } | 'daily'
+   {
+           $table.set("H H * * *",getHashForTokens());
+         } | 'midnight'
+   {
+           $table.set("H H(0-2) * * *",getHashForTokens());
+         } | 'hourly'
+   {
+           $table.set("H * * * *",getHashForTokens());
+         }))
+   ;
+
+expr[int field] returns[long bits=0] locals[long lhs, long rhs=0]
+   : term[field]
+   { $lhs = $term.ctx.bits; } (OR expr[field]
+   { $rhs = $expr.ctx.bits; })?
+   {
+  $bits = $lhs|$rhs;
+ }
+   ;
+
+term[int field] returns[long bits=0] locals[int d=NO_STEP, int s, int e]
+   : token
+   { $s=$token.ctx.value; } MINUS token
+   { $e=$token.ctx.value; } (DIV token
+   { $d=$token.ctx.value; })?
+   {
+     $bits = doRange($s,$e,$d,$field);
+   }
+   | token
+   {
+     rangeCheck($token.ctx.value,$field);
+     $bits = 1L<<$token.ctx.value;
+   }
+   | STAR (DIV token
+   { $d=$token.ctx.value; })?
+   {
+     $bits = doRange($d,$field);
+   }
+   | 'H' LPAREN token
+   { $s=$token.ctx.value; } MINUS token
+   { $e=$token.ctx.value; } RPAREN (DIV token
+   { $d=$token.ctx.value; })?
+   {
+     $bits = doHash($s,$e,$d,$field);
+   }
+   | 'H' (DIV token
+   { $d=$token.ctx.value; })?
+   {
+     $bits = doHash($d,$field);
+   }
+   ;
+
+token returns[int value=0]
+   : TOKEN
+   {
+     $value = Integer.parseInt($TOKEN.getText());
+   }
+   ;
+