Remove node.version and npm.version defaults #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
reviewed
Oct 5, 2022
basil
requested changes
Oct 10, 2022
Member
basil
left a comment
basil
left a comment
There was a problem hiding this comment.
Two paths forward: (1) accepting the suggestion made previously to remove the version numbers from this file, or (2) updating the version numbers in this file and filing downstream PRs for all consumers to stop setting custom versions in favor of the global versions being proposed in this PR.
NotMyFault
changed the title
Co-authored-by: Basil Crow <[email protected]>
Member
Author
|
Your proposal makes more sense then, given almost every consumer did already define their own properties. Do we want to label this as |
basil
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change proposed updates the couple of dependencies to their maintained LTS versions, instead of shipping a version that is ~8 years out of date (and 6 years out of maintenance).