feat: Bind host configuration to job using id instead of name

src/main/java/jenkins/plugins/publish_over_ssh/BapSshHostConfiguration.java

@@ -34,6 +34,7 @@
 import java.util.Properties;
 
 import hudson.util.Secret;
+import java.util.UUID;
 import jenkins.model.Jenkins;
 import jenkins.plugins.publish_over.*;
 import jenkins.plugins.publish_over_ssh.descriptor.BapSshHostConfigurationDescriptor;
@@ -64,6 +65,7 @@ public class BapSshHostConfiguration extends BPHostConfiguration<BapSshClient, B
 
     public static final boolean DEFAULT_AVOID_SAME_FILES_UPLOAD = false;
 
+    private String id;
     private int timeout;
     private boolean overrideKey;
     private boolean disableExec;
@@ -87,6 +89,7 @@ public BapSshHostConfiguration() {
         // business logic in there...
         super(null, null, null, null, null, 0);
         this.keyInfo = new BapSshKeyInfo(null, null, null);
+        this.id = UUID.randomUUID().toString();
     }
 
     // CSOFF: ParameterNumberCheck
@@ -102,6 +105,11 @@ public BapSshHostConfiguration(final String name, final String hostname, final S
         this.keyInfo = new BapSshKeyInfo(encryptedPassword, key, keyPath);
         this.disableExec = disableExec;
         this.avoidSameFileUploads = avoidSameFileUploads;
+        this.id = StringUtils.isEmpty(id) ? UUID.randomUUID().toString() : id;
+    }
+
+    public String getId() {
+        return id;
     }
 
     @DataBoundSetter
@@ -499,6 +507,7 @@ protected HashCodeBuilder addToHashCode(final HashCodeBuilder builder) {
     @Override
     protected ToStringBuilder addToToString(final ToStringBuilder builder) {
         return super.addToToString(builder)
+                .append("id",id)
                 .append("keyInfo", keyInfo)
                 .append("timeout", timeout)
                 .append("overrideKey", overrideKey)

src/main/java/jenkins/plugins/publish_over_ssh/descriptor/BapSshPublisherPluginDescriptor.java

@@ -113,9 +113,9 @@ public List<BapSshHostConfiguration> getHostConfigurations() {
         return retVal;
     }
 
-    public BapSshHostConfiguration getConfiguration(final String name) {
+    public BapSshHostConfiguration getConfiguration(final String identifier) {
         for (BapSshHostConfiguration configuration : hostConfigurations) {
-            if (configuration.getName().equals(name)) {
+            if (configuration.getId().equals(identifier) || configuration.getName().equals(identifier)) {
                 return configuration;
             }
         }
@@ -124,7 +124,7 @@ public BapSshHostConfiguration getConfiguration(final String name) {
 
     /**
      * Add a Host Configuration to the list of configurations.
-     * 
+     *
      * @param configuration Host Configuration to add. The common configuration will be automatically set.
      */
     public void addHostConfiguration(final BapSshHostConfiguration configuration) {
@@ -134,7 +134,7 @@ public void addHostConfiguration(final BapSshHostConfiguration configuration) {
 
     /**
      * Removes the given named Host Configuration from the list of configurations.
-     * 
+     *
      * @param name The Name of the Host Configuration to remove.
      */
     public void removeHostConfiguration(final String name) {

src/main/resources/jenkins/plugins/publish_over_ssh/BapSshHostConfiguration/config.jelly

@@ -28,6 +28,11 @@
 
     <poj:defaultMessages/>
 
+    <f:invisibleEntry>
+      <f:entry title="ID" field="id">
+        <f:textbox/>
+      </f:entry>
+    </f:invisibleEntry>
     <f:entry title="${m.name()}" field="name">
         <f:textbox/>
     </f:entry>

src/main/resources/jenkins/plugins/publish_over_ssh/BapSshPublisher/config.jelly

@@ -31,7 +31,7 @@
     <f:entry title="${m.hostconfig()}" field="configName">
         <select class="setting-input ssh-config-name" name="configName">
             <j:forEach var="s" items="${descriptor.publisherPluginDescriptor.hostConfigurations}">
-                <f:option value="${s.name}" selected="${s.name==instance.configName or ( instance==null and s.name==defaults.publisher.configName ) }">${s.name}<j:if test="${s.effectiveDisableExec}">${%hostconfig.noexec.suffix}</j:if></f:option>
+              <f:option value="${(s.id==null or s.id=='') ? s.name : s.id}" selected="${s.id==instance.configName or s.name==instance.configName or ( instance==null and s.id==defaults.publisher.configName ) }">${s.name}<j:if test="${s.effectiveDisableExec}">${%hostconfig.noexec.suffix}</j:if></f:option>
             </j:forEach>
         </select>
     </f:entry>