Modernization #36
Closed
Modernization #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plugins into distinct steps. It allows modernizing all tooling up to the last versions that supported Java 8. This can then be followed by another recipe that makes the jump to Java 11."
…plugins into distinct steps. It allows modernizing all tooling up to the last versions that supported Java 8. This can then be followed by another recipe that makes the jump to Java 11."
…uctor of SectionedViewSection. This is a potential issue because if a subclass overrides this method, the overridden version will be called before the subclass constructor has run, which can lead to unexpected behavior or errors. In the corrected code, I've replaced the call to initJobFilters in the constructor with the code that initJobFilters would execute. This ensures that the jobFilters field is initialized correctly without calling an overridable method.
Author
|
The build fails because this PR is not compatible with JDK8 anymore. |
mbSmaga
requested changes
Dec 16, 2023
Contributor
mbSmaga
left a comment
mbSmaga
left a comment
There was a problem hiding this comment.
Thanks for your work! Before merging, I'd like to take some time for testing those changes if that's ok. In the meantime, could you please clean up the git commit history?
src/main/java/hudson/plugins/sectioned_view/FolderViewSection.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Michał Smaga <[email protected]>
"This recipe is intended to break down the modernization of very old plugins into distinct steps. It allows modernizing all tooling up to the last versions that supported Java 8. This can then be followed by another recipe that makes the jump to Java 11." Commons lang More recent version of mockito. Compiles JDK21 JDK21 fdfsfs Removed SpotBugs issues. Removed SpotBugs found issues. Removed SpotBugs found issues. Use https: for scm URL, not git: Corrected SpotBugs found issues. Increase SpotBugs checks. The overridable method initJobFilters is being called from the constructor of SectionedViewSection. This is a potential issue because if a subclass overrides this method, the overridden version will be called before the subclass constructor has run, which can lead to unexpected behavior or errors. In the corrected code, I've replaced the call to initJobFilters in the constructor with the code that initJobFilters would execute. This ensures that the jobFilters field is initialized correctly without calling an overridable method. Automate dependency updates Publish incremental development artifacts Scan all items for matching regular expression Implement the option to execute the regular expression on all jobs (old behavior) Match the name of existing option from List View for consistency Update changelog [maven-release-plugin] prepare release sectioned-view-1.26 [maven-release-plugin] prepare for next development iteration Update changelog Update src/main/java/hudson/plugins/sectioned_view/FolderViewSection.java Co-authored-by: Michał Smaga <[email protected]>
Contributor
|
Hi @gounthar, are you still working on that? Have you seen comments above? I could take over if you are busy with other things. |
mawinter69
reviewed
Jul 28, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 and would like the most used plugins to be compiled and tested with Java 21.
The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.
The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.
Testing done
Confirmed tests pass with Java 21 on Linux.
Submitter checklist
Link to relevant issues in GitHub or Jira