Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix findbugs warnings in ExponentialDelay, RandomDelay and RandomExpo…
…nentialDelay
  • Loading branch information
JoaoPPinto committed Aug 24, 2021
commit 773c708ed1d9f920289ee628fc0f75ef2ff79a74
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@
@Extension
public class ExponentialDelay extends RetryDelay implements Serializable {

private static final int base = 2;

private final long min;
private final long max;
private final int multiplier;
private final int base = 2;
private int lastMultiplier = 0;

public ExponentialDelay() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@
@Extension
public class RandomDelay extends RetryDelay implements Serializable {

private static final Random RANDOM = new Random();

private final int min;
private final int max;
private Random random = new Random();

public RandomDelay() {
super();
Expand All @@ -42,11 +43,11 @@ public long getMax() {

@Override
public long computeRetryDelay() {
long delay = min;
long delay;
if(min == max) {
delay = min;
} else {
delay = random.nextInt(max-min) + min;
delay = RANDOM.nextInt(max-min) + min;
}

return unit.toMillis(delay);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,13 @@
@Extension
public class RandomExponentialDelay extends RetryDelay implements Serializable {

private static final int base = 2;
private static final Random RANDOM = new Random();

private final int multiplier;
private final int max;
private final int base = 2;
private boolean largerThanMax = false;
private int lastMultiplier = 0;
private Random random = new Random();

public RandomExponentialDelay() {
super();
Expand All @@ -48,9 +49,9 @@ public long getMax() {

@Override
public long computeRetryDelay() {
long delay = 0;
long delay;
if(largerThanMax) {
delay = 1 + random.nextInt(max);
delay = 1 + RANDOM.nextInt(max);
} else {
if(lastMultiplier > 0) {
lastMultiplier += 1;
Expand Down