Bump plugin from 4.48 to 4.49 #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Oct 31, 2022
Member
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Tried interactively and the basics of the Pipeline editor seem to be working.
Member
Author
|
Rephrased https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.49, to highlight what users need to look for when specifying a version. |
jglick
reviewed
Oct 31, 2022
| <groovy-cps.version>1.34</groovy-cps.version> | ||
| <node.version>16.17.0</node.version> | ||
| <npm.version>8.18.0</npm.version> | ||
| <yarn.version>1.22.19</yarn.version> |
Member
There was a problem hiding this comment.
Not listed on https://github.com/yarnpkg/berry/releases; is this just the previous hard-coded value or something?
Member
Author
There was a problem hiding this comment.
This is the last release of the 1.x line. 1.x is unsupported for several years, but the current supported line, berry (3.x), requires jenkinsci/plugin-pom#625 on our end first, before working out of the box.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up #601 (comment)
@jglick 4.49 removed the default the versions set for yarn, node and npm. This repository uses all three tools, but did declare
<node.version>and<npm.version>only.This PR demonstrates how to upgrade to 4.49 by specifying
<yarn.version>.I'll add a few links to the 4.49 changelog where to obtain these versions from. I'd assume that makes it easier for users to upgrade?
Closes #601