Fix issue where Safari attempts to select text during drag operations #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for PR! On linux I don't have an official access to safari. I have done a test with the browser: https://wiki.gnome.org/Apps/Web which is based on webkit. Does it also happen when dragging a node? drawflow-safari.mp4 |
Contributor
Author
|
Yes, I had not noticed that was happening too. I have updated the PR so that if the code decided a node drag had started it will also preventDefault. |
Owner
|
Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was testing this fantastic library I found that desktop Safari would attempt to do unwated text selection during drag operations. This PR resolves that issue.