Signed-off-by checker in precommit testing script

[ruben-ayrapetyan]

Hello.

We could add check for correctness of Signed-off-by tag into tools/precommit.sh.

For example, we could check, that the tag is placed at last line of commit message and is composed of exactly the following three parts, splitted by space character: common prefix, name and e-mail of the commit's author.

[galpeter]

I'm not sure that the merged solution is really good. The precommit should mean it is executed before the commit, but this just simply checks that last commit's signed-off-by line, which does not mean that it's your modification.

IMHO: a better way would be to use git hooks. to check if the signed-off-by is present in the commit message. There is already an example related to this in all git repos, just see the .git/hooks/commit-msg.sample.

Another one: why is this a "Core ECMA feature"?

[ruben-ayrapetyan]

@galpeter ,

The precommit should mean it is executed before the commit, but this just simply checks that last commit's signed-off-by line, which does not mean that it's your modification.

The precommit testing is just the testing that should pass successfully on every pushed commit.
One can commit locally anything, and the precommit is not required to pass until the commit is pushed.

Precommit testing can be started by a commit's author to check it before push / creating pull request, by person who merges commit before merging if that is required by some rules, etc.

By the way, can the git-hooks be committed / pushed / pulled as other changes?

Another one: why is this a "Core ECMA feature"?

This is name of milestone, and milestone means specific date.
So, this means, that the issue is to be solved until the milestone.

[egavrin]

@ruben-ayrapetyan , in the case changes are not committed, the signed-off-by checker would check previous commit. In the case, this could be ignored.