Fix property lookup in Object.getOwnPropertyDescriptor. #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galpeter
added
bug
|
@kkristof, could you take a look? |
|
lgtm |
|
|
The ecma_op_general_object_get_own_property call does not find all properties, we need to use the ecma_op_object_get_own_property method for correct property lookup. JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
force-pushed
the
fix_object_get_own_property_descriptor
branch
from
3f8c03c to
c3f9169
Compare
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ecma_op_general_object_get_own_property call does not find all
properties, we need to use the ecma_op_object_get_own_property method
for correct property lookup.
JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]