Fix ecma_get_property_descriptor_from_property function #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we somehow add a test case for this? |
|
Not really because the problems came up when I started to implement the seal function. The getOwnPropertyDescriptor's test however test this (there was a missing property_descriptor free) because otherwise it would raise assertion in the property_descriptor free function. |
|
It is better now? |
egavrin
added
ecma builtins
|
Good to me. |
|
yeah, lgtm also |
|
|
JerryScript-DCO-1.0-Signed-off-by: Kristof Kosztyo [email protected]
|
Rebased & merged in: 013bce8 |
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Kristof Kosztyo [email protected]