Fix valgrind false-positive warning in mem_heap_get_chunked_block_start #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-ayrapetyan
added
bug
|
@galpeter, could you, please, review the change? |
|
Well. I don't really know the valgrind's macros so I'll just assume that it is correct :) |
|
@galpeter, Marking access with the macro, we provide access to heap-internal structures only to |
|
@ruben-ayrapetyan I see, thanks for the information. With this extra info it really does make sense. |
|
@galpeter, ok. thank you for review. |
|
|
JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
ruben-ayrapetyan
force-pushed
the
Ruben-fix-valgrind-false-positive-warning
branch
from
1499bf8 to
7d4569a
Compare
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.