Skip to content

Conversation

DanielBallaSZTE
Copy link

Also improve readability in the function by renaming the variables to better represent their functionality.

Fixes #3105

JerryScript-DCO-1.0-Signed-off-by: Daniel Balla [email protected]

@rerobika rerobika requested a review from dbatyai September 13, 2019 14:20
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika added bug Undesired behaviour ES2015 Related to ES2015 features labels Sep 13, 2019
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit aa8832a into jerryscript-project:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour ES2015 Related to ES2015 features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion 'ecma_string_get_size (string_p) <= buffer_size' in ecma-helpers-string.c

4 participants