Skip to content

Implement builtin getters for Date object #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2015
Merged

Implement builtin getters for Date object #334

merged 1 commit into from
Jul 9, 2015

Conversation

szledan
Copy link
Contributor

@szledan szledan commented Jul 8, 2015

JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan [email protected]

@egavrin egavrin added this to the ECMA builtins milestone Jul 8, 2015
@egavrin egavrin added ecma builtins Related to ECMA built-in routines development Feature implementation labels Jul 8, 2015
egavrin
egavrin reviewed Jul 8, 2015
View reviewed changes
jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_p

@szledan szledan force-pushed the date_prototype_getters branch 2 times, most recently from 5a74628 to 9b33cdd Compare July 8, 2015 14:48
@galpeter galpeter mentioned this pull request Jul 8, 2015
Closed
50 tasks
@szledan
Copy link
Contributor Author

szledan commented Jul 9, 2015

Hi, I've updated this PR.

@egavrin
Copy link
Contributor

egavrin commented Jul 9, 2015

Good to me.

@kkristof
Copy link
Contributor

kkristof commented Jul 9, 2015

Could you add some tests? Otherwise the patch looks good.

@szledan
Copy link
Contributor Author

szledan commented Jul 9, 2015

Sure

@szledan szledan force-pushed the date_prototype_getters branch from 9b33cdd to 468182e Compare July 9, 2015 14:27
@kkristof
Copy link
Contributor

kkristof commented Jul 9, 2015

lgtm

@egavrin
Copy link
Contributor

egavrin commented Jul 9, 2015

make push

@szledan
Implement builtin getters for Date object
8d7cdeb 
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan [email protected]
@szledan szledan force-pushed the date_prototype_getters branch from 468182e to 8d7cdeb Compare July 9, 2015 15:05
@kkristof kkristof merged commit 8d7cdeb into jerryscript-project:master Jul 9, 2015
@galpeter galpeter mentioned this pull request Jul 10, 2015
Closed
@szledan szledan deleted the date_prototype_getters branch July 15, 2015 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

development Feature implementation ecma builtins Related to ECMA built-in routines

Projects

None yet

Milestone

ECMA builtins

Development

Successfully merging this pull request may close these issues.

4 participants

@szledan @egavrin @kkristof @zherczeg