Skip to content

Add locale part of the toString in the Date object #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2015
Merged

Add locale part of the toString in the Date object #416

merged 1 commit into from
Jul 16, 2015

Conversation

szledan
Copy link
Contributor

@szledan szledan commented Jul 16, 2015

JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan [email protected]

@galpeter
Copy link
Contributor

by local don't you mean locale?

@szledan
Copy link
Contributor Author

szledan commented Jul 16, 2015

Yes, it's true.. (Typo)

@szledan
Add locale part of the toString in the Date object
351df61 
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan [email protected]
@szledan szledan force-pushed the date_prototype_toLocal branch from 7f1e530 to 351df61 Compare July 16, 2015 11:05
@szledan szledan changed the title Add local part of the toString in the Date object Add locale part of the toString in the Date object Jul 16, 2015
@egavrin egavrin added this to the ECMA builtins milestone Jul 16, 2015
@egavrin egavrin added ecma builtins Related to ECMA built-in routines development Feature implementation labels Jul 16, 2015
@egavrin
Copy link
Contributor

egavrin commented Jul 16, 2015

Ok for mew

@galpeter
Copy link
Contributor

yep, lgtm also

@egavrin
Copy link
Contributor

egavrin commented Jul 16, 2015

I'll push

@egavrin egavrin merged commit 351df61 into jerryscript-project:master Jul 16, 2015
@galpeter galpeter mentioned this pull request Jul 16, 2015
Closed
50 tasks
@egavrin
Copy link
Contributor

egavrin commented Jul 16, 2015

Merged at 351df61

@szledan szledan deleted the date_prototype_toLocal branch July 20, 2015 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

development Feature implementation ecma builtins Related to ECMA built-in routines

Projects

None yet

Milestone

ECMA builtins

Development

Successfully merging this pull request may close these issues.

3 participants

@szledan @galpeter @egavrin