Skip to content

Conversation

@rerobika
Copy link
Member

@rerobika rerobika commented Jan 18, 2021

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

@rerobika rerobika added the bug Undesired behaviour label Jan 18, 2021
Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor style change request, otherwise lgtm

@rerobika rerobika changed the title Add async and generator function support for export default statement Rework export default parsing Jan 19, 2021
@rerobika rerobika force-pushed the fix_4150 branch 2 times, most recently from f78c92f to b2fde63 Compare January 19, 2021 14:16
- Remove SCANNER_LITERAL_POOL_DEFAULT_CLASS_NAME workaround
- Add async and generator function support
- Fix auto semicolon insertion after export statement
- fixes jerryscript-project#4150.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika requested a review from galpeter January 19, 2021 15:17
Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rerobika rerobika merged commit bf7fa39 into jerryscript-project:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion 'scope_stack_p >= context_p->scope_stack_p' in parser_parse_function_statement

3 participants