Tab removal #753
Merged
Tab removal #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
Also changed space-based indentation in touched files if they used 4 spaces for indentation (instead of the most-often-used 2). Also added new line to end of touched files if they did not end that way. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
|
LGTM |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can call me names... but tabs are evil...
When I touched CMakeLists.txt last time, I've seen some tabs lurking there. I've made a vow to eliminate them. Then I looked around and found some more. These three patches kill'em all in three parts of the repository: in CMakeLists.txt, in the tools directory, and among the tests.
Side note: there are quite some style issues left over in the tests (number of spaces used for indentation, presence vs absence of space between function names and parameter lists, placement of curly braces, etc) but these patches do not intend to unify them.