Implemented Array.prototype.filter()

[dbatyai]

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]

[galpeter]

lgtm

[ruben-ayrapetyan]

This is part of step 3, isn't it?

[ruben-ayrapetyan]

Please, change the assertion to ecma_is_completion_value_normal_true (put_comp_value).

[dbatyai]

I've updated the patch.

[egavrin]

/jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp: In function ‘ecma_completion_value_t ecma_builtin_array_prototype_object_filter(ecma_value_t, ecma_value_t, ecma_value_t)’:
/jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp:794:49: error: ‘to_object_comp’ was not declared in this scope
     func_object_p = ecma_get_object_from_value (to_object_comp);
                                                 ^
compilation terminated due to -Wfatal-errors.

[ruben-ayrapetyan]

What is the to_object_comp? Why should it be freed?

[dbatyai]

@egavrin, @ruben-ayrapetyan sorry, fixed

[ruben-ayrapetyan]

make push

[egavrin]

@dbatyai @ruben-ayrapetyan Nope ^_^, wrong email

+ make precommit -j4
�[1;33m Signed-off-by message is incorrect. The following line should be at the end of the ed47d2279a9758ee3e82f7dac87f3dccdd9dc566 commit's message: 'JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]'.

[ruben-ayrapetyan]

@egavrin , ed47d2279a9758ee3e82f7dac87f3dccdd9dc566 seems to be another commit.
The commit in the pull request is a80282a.

In other, already merged, commits the [email protected] e-mail is used.

[egavrin]

@ruben-ayrapetyan ah, my bad.
make push

[dbatyai]

merged: 3329583