Add STRIP_RELEASE_BINARY option to Makefile
#928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
added
enhancement
akosthekiss
force-pushed
the
makefile-add-strip-option
branch
from
3537437 to
337ce93
Compare
|
Isn't this the default? |
|
On Linux, Darwin, and OpenWRT targets, this is ON by default, on MCU targets, the default is OFF. It'd be good to have a way of overriding it. E.g., I'd like to have symbols in my release linux binaries to be able to get at least somewhat meaningful objdumps/disassemblies -- this would need turning that option OFF. (According to my understanding, it has no effect on the "important" parts of the binary, e.g., on text and data sizes.) |
|
LGTM |
1 similar comment
|
LGTM |
It is already supported by CMakeLists, might be useful to allow it to be passed through Makefile. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
akosthekiss
force-pushed
the
makefile-add-strip-option
branch
from
337ce93 to
c0f3a9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is already supported by CMakeLists, might be useful to allow it
to be passed through Makefile.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]