Fix precommit scripts on OSX #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franc0is
force-pushed
the
fix-precommit-osx
branch
from
2ac9bf4 to
6f2b200
Compare
|
LGTM |
| if [[ "$OSTYPE" == "linux"* ]]; then | ||
| CPPCHECK_JOBS=${CPPCHECK_JOBS:=$(nproc)} | ||
| elif [[ "$OSTYPE" == "darwin"* ]]; then | ||
| CPPCHECK_JOBS=${CPPCHECK_JOBS:=$(sysctl -n hw.ncpu)} |
There was a problem hiding this comment.
Thanks for getting this work on OSX! This script becomes just a little bit incomplete, however. Please, add a final else branch that sets CPPCHECK_JOBS to something basic default, just to make sure that the script doesn't break. (E.g., if someone builds on freebsd, or whatever.) I'd go for a default of 1.
|
LGTM |
|
(After the else fix). |
JerryScript-DCO-1.0-Signed-off-by: François Baldassari [email protected]
franc0is
force-pushed
the
fix-precommit-osx
branch
from
6f2b200 to
b59af40
Compare
|
Added the else clause and rebased on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: François Baldassari [email protected]