export: ignore filters with empty action #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I must have created a filter with a label, then deleted the label, and the filter was left with no action. Handle this case to prevent a crash at when Action is nil and dereferenced. Signed-off-by: Anisse Astier <[email protected]>
parkr
approved these changes
May 22, 2019
parkr
left a comment
parkr
left a comment
There was a problem hiding this comment.
I was bit by this today as well. Thank you for submitting a patch!
|
Interestingly, exporting showed a number of these in the resulting config: |
|
I too have a large number of the above mentioned block in my export. I suspect, but have not yet fully proven #11 as the cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I must have created a filter with a label, then deleted the label, and
the filter was left with no action. Handle this case to prevent a crash
at when Action is nil and dereferenced.
Signed-off-by: Anisse Astier [email protected]