feat: create prefer-mock-promise-shorthand rule
#1167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
create-prefer-mock-promise-shorthand
branch
from
2c0a4c2 to
087b1c2
Compare
SimenB
reviewed
Jul 19, 2022
G-Rath
force-pushed
the
create-prefer-mock-promise-shorthand
branch
from
087b1c2 to
460fa5f
Compare
G-Rath
force-pushed
the
create-prefer-mock-promise-shorthand
branch
from
460fa5f to
dbd72a2
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
# [26.7.0](v26.6.0...v26.7.0) (2022-07-29) ### Features * create `prefer-mock-promise-shorthand` rule ([#1167](#1167)) ([d965592](d965592))
|
🎉 This PR is included in version 26.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided not to do
jest.fn(...)because it's sort of an odd duck where I could the case being made that people want to stick with usingmockImplementationwhen they're using the other methods for consistency + thatjest.fn(() => Promise.resolve(...))is not as much improved being written asjest.fn().mockResolvedValue(...)as what this rule currently covers.Resolves #104